Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple schemas #389

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Support multiple schemas #389

merged 1 commit into from
Oct 21, 2018

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Oct 18, 2018

Not quite what was wanted in #383, but import syntax is still not in the spec and there are many other concerns around namespacing etc.

This basically just concatenates the files, but keeps file names and line numbers accurate.

related reading:

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@sandeepone
Copy link

I like the idea and look good. Didn't have time to test it. I can avoid go bindata for schema generation now. Thanks.

@vektah vektah requested a review from mathewbyrne October 18, 2018 20:30
@JulienBreux
Copy link

@vektah remind me to send to you a beer :) 🍻

@vektah vektah merged commit 3447dd2 into master Oct 21, 2018
@vektah vektah deleted the multiple-schemas branch October 21, 2018 09:09
@jbltx
Copy link

jbltx commented Jan 7, 2019

Sorry i'm late but is there any plan for merging type definitions instead of simple concatenation ?

Example :
https://github.com/okgrow/merge-graphql-schemas#merging-type-definitions

cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants